When reviewing code, we’re often so focused on finding problems that we forget to zero in on those within the team submitting perfect commits. When your developer understands the issue at hand, breaks it into smaller tasks, and presents near-perfect code, remember to take a moment to applaud them. Taking note not only buoys the whole team, but it also gives everyone an example of what to work towards.
Do you use Git and Jira?
Take them to the Next Level with our Git-Jira integration
→ Try it For Free ←
While not all commits will be perfect, the ones that are tend to have a significant impact. Not only is the code more robust, but they’re also reviewed and approved on the first round, which means less work for all involved, saving time and moving everyone closer to a finished sprint.
That’s why it’s essential to recognize the moment!
How to Recognize Near Perfect Commits
Typically, a perfect commit (or bullseye) can be recognized by:
- When they were submitted (in relation to a deadline)
- How they were structured (short and sweet)
- How they were treated during review (passed the tets with flying colors)
An outstanding commit is typically submitted well in advance of the deadline, with little to no churn, and likely approved on the first review.
How to Leverage Successful Commits
Just as improvement areas are pointed out, so should notable commits. It’s a good idea to do it publicly, in a stand-up, or even in a simple note to the engineer. By making a public statement, you highlight to your team a positive aspect of someone’s work and help to reinforce a virtuous cycle of positive energy.
If there’s a specific developer that’s consistently hitting a bullseye, look at their approach. Whatever their process, it may be helpful for other team members to understand it so that they can mirror it in the future, hopefully leading to fewer rejected reviews and lower churn.
Finding those developers and getting them to assist in providing feedback to other team members – especially junior developers – as their insights and guidance may also be helpful.
Conclusion
It’s essential to not just point out specific issues with commits – whether it’s high churn or code hoarding. By putting just as much emphasis on the positive, you show your appreciation for a job well done and give direction to an entire team. If they know what to strive for, chances are everyone will begin to pull in the same direction. By highlighting perfectly executed examples, you give them real-world insight into how they should think about their commit submissions in the future.
Need help integrating Git and Jira? Download our Git-Jira integration app and manage your Git right from Jira/ Find this and many more great Git-Jira plugins (including Bitbucket, GitHub, Gitlab) right on the Atlassian Marketplace.
Want more Bitband insights? Check out: